fix(compiler-cli): allow '==' to compare nullable types #16731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: angular#16729 * fix(compiler-cli): diagnose issues in conditional of ternary Fixes: angular#16730
tbosch
approved these changes
May 16, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
Fixes: angular#16729 * fix(compiler-cli): diagnose issues in conditional of ternary Fixes: angular#16730
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
Fixes: angular#16729 * fix(compiler-cli): diagnose issues in conditional of ternary Fixes: angular#16730
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16729
Fixes: #16730
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Comparing a nullable type with a non-nullable type produces an error.
What is the new behavior?
No error is reported.
Does this PR introduce a breaking change? (check one with "x")